search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
654 stars 201 forks source link

Avoiding setAttribute() side effects. #488

Closed delapuente closed 7 years ago

delapuente commented 7 years ago

While optimizing components for the clipboard representation, calling setAttribute() directly could have side effects on entity's components already processed (such as re-setting properties already removed). To avoid side effects, HTMLElement original setAttribute() and removeAttribute() functions are used instead.

fernandojsg commented 7 years ago

Perfect, thanks! ;)

fernandojsg commented 7 years ago

@delapuente I've just reverted it because of the issue related to the position format that it generates