search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
654 stars 201 forks source link

Focusing on a Text component crashes the tab requiring restart. #538

Closed Adam4lexander closed 5 years ago

Adam4lexander commented 6 years ago

Caused by Box3.setFromObject() in threejs assuming that objects use 3 numbers per vertex position. The TextGeometry only uses 2 numbers per vertex position.

I'm going to take a look at this soon, I think the fix should be in THREE.Box3.

Adam4lexander commented 6 years ago

https://github.com/mrdoob/three.js/pull/13622

Made a pr to three to fix this.

ngokevin commented 5 years ago

i think i fixed by monkeypatching the box3, but new versions of three works too now