search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
654 stars 201 forks source link

fix prettier eslint #581

Closed lazychip closed 1 year ago

lazychip commented 5 years ago

When i cloned the repo and started to look the code eslint is so messed up and all those end lines with my eslint on 😖.
I have added prettier-eslint to fix the code and husky hooks on precommit to future save the code.

ngokevin commented 5 years ago

I just have the codebase on Prettier. I don't think it matters much to use Prettier vs. ESLint, so it's okay to just keep it on Prettier? More common in React/JSX codebases.

lazychip commented 5 years ago

Personally i like eslint and I think eslint, prettier codebase is more common in React/JSX. Its okay to keep the codebase on Prettier but i think if you want to continue the codebase on prettier only then remove the eslint config from the codebase to avoid the confusion for the contributors.

vincentfretin commented 1 year ago

@dmarcos Please close this one. All eslint errors are fixed by #639 and the prettier reformat will be done in #647

dmarcos commented 1 year ago

Close in favor of https://github.com/aframevr/aframe-inspector/pull/647