search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
654 stars 201 forks source link

Fix inspector toggle on US international keyboards #598

Closed svenkonings closed 1 year ago

svenkonings commented 4 years ago

Fixes issue #595 See also issue aframevr/aframe#4089

On US international keyboards Ctrl + Alt are combined into AltGraph. When this happens Ctrl and Alt are registered as unpressed, breaking the toggle expression

This is fixed by adding an additional clause for the AltGraph combination.

svenkonings commented 3 years ago

The keyboard shortcut in aframe-inspector should also be updated now aframevr/aframe#4516 has been merged.

vincentfretin commented 1 year ago

@dmarcos you should really merge this one. It will allow to use the same shortcut to close the inspector. On a French keyboard, AltGr is a real key. I can currently open the inspector with Ctrl+Alt+i or AltGr+i (shortcut defined in the aframe inspector component). But I can only close the inspector with Ctrl+Alt+i (the shortcut defined here in aframe-inspector). If you merge this, I will be able to close with AltGr+i as well.

vincentfretin commented 1 year ago

@dmarcos the fix of this PR is included in #647 after prettier reformatting.

dmarcos commented 1 year ago

@vincentfretin Thanks. I can close. For https://github.com/aframevr/aframe-inspector/pull/647 might be good to break into separate PRs. It seems it's already including a lot of stuff

Closed in favor of https://github.com/aframevr/aframe-inspector/pull/647