Updates to support recent three.js/a-frame use of ES6 classes.

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.

https://aframe.io/aframe-inspector/examples/

MIT License

654 stars 201 forks source link

Updates to support recent three.js/a-frame use of ES6 classes. #627

Closed donmccurdy closed 2 years ago

donmccurdy commented 2 years ago

Updates to get the inspector working with recent three.js versions. Tested:

A-Frame Version: 1.2.0 (Date 2021-10-18, Commit #b1b13381)
index.js:94 THREE Version (https://github.com/supermedium/three.js): ^0.133.5

Changes:

Fixes https://github.com/aframevr/aframe-inspector/issues/625
Refactor TransformControls to use ES6 classes.
Update Babel to avoid transpiling ES6 classes.

References:

https://stackoverflow.com/a/47356121/1314762

donmccurdy commented 2 years ago

Changes, without whitespace: https://github.com/aframevr/aframe-inspector/pull/627/files?w=1

donmccurdy commented 2 years ago

One heads up on this - I'm not sure it's possible to support both new and old versions of threejs without bundling two versions of this file, since ES6 classes and prototypal classes don't play well together. This PR is currently not backward compatible.

dmarcos commented 2 years ago

Yeah! Don to the rescue. Thanks so much.

I don't think we need backwards compatibility. A-Frame 1.2.0 will be locked to an old version of the inspector. Future version of A-Frame (master already on r133) will use this.

dmarcos commented 2 years ago

⭐ ⭐ ⭐ ⭐ ⭐ Thanks so much.

donmccurdy commented 2 years ago

A-Frame 1.2.0 will be locked to an old version of the inspector. Future version of A-Frame (master already on r133) will use this.

Awesome, that sounds good!