Add 'terser-webpack-plugin-legacy'

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.

https://aframe.io/aframe-inspector/examples/

MIT License

654 stars 201 forks source link

Add 'terser-webpack-plugin-legacy' #629

Closed donmccurdy closed 2 years ago

donmccurdy commented 2 years ago

Fixes #628, #625.

Fixes minified builds; unminified builds were already working.

This PR is intended to be the minimum set of dependency updates needed to get the Inspector working with ES6 Classes, following up from #627. The version of UglifyJS bundled with older Webpack versions didn't support ES6, so I'm bumping to Webpack 3 and installing Terser. Minified bundle size decreases from 440kb to 410kb.

donmccurdy commented 2 years ago

@dmarcos just FYI, I think this PR is a necessary part of #627.

kfarr commented 2 years ago

Getting support requests on this from users not able to build. Any issues to resolve before ok to merge @dmarcos ?

dmarcos commented 2 years ago

Thank you for the reminder. I missed this.