search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
654 stars 201 forks source link

Adjustments for THREE r144 #637

Closed vincentfretin closed 1 year ago

vincentfretin commented 2 years ago

Some fixes to work with aframe master (tested against three r141 and not r144 because there is no updated build currently on aframe repo) and fixing some issues I found while testing, see each commit for details.

kylebakerio commented 1 year ago

I tested the provided demo scene pretty thoroughly, was not able to get any inspector-specific issues to occur. This is great work that really fixes a lot of nagging minor issues that have plagued the inspector for some time and bring it up to date, great stuff.

kylebakerio commented 1 year ago

I made a pull request against aframe-environment-component accordingly, here.

dmarcos commented 1 year ago

Can we separate in different PRs the adjustments for THREE r144 and the rest?

vincentfretin commented 1 year ago

Sure, I rebased and kept only relevant commits to the threejs upgrade. The other commits are in #638

dmarcos commented 1 year ago

Thank you! 👏