search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
654 stars 201 forks source link

Update all the dependencies, mainly webpack and react #641

Closed vincentfretin closed 1 year ago

vincentfretin commented 1 year ago

I have a version of the inspector working with react 18.2.0, mainly changes about string refs that needs to be replaced by React.createRef, and componentWillReceiveProps by componentDidUpdate or getDerivedStateFromProps. I'm waiting for #638 and #639 to be merged first, then I can proceed updating webpack to version 5, babel, react and other dependencies.

This will fix #606

vincentfretin commented 1 year ago

This will replace the PR #601

vincentfretin commented 1 year ago

For reference, the repo currently uses react 15.6.2.

vincentfretin commented 1 year ago 
npm run lint
src/components/components/Mixins.js
  20:5  error  Do not use setState in componentDidUpdate  react/no-did-update-set-state

=> modify it to use getDerivedStateFromProps