aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
655 stars 203 forks source link

Fix panels disappearing when selecting a-videosphere entity #680

Closed vincentfretin closed 1 year ago

vincentfretin commented 1 year ago

See details of the debugging issue in https://github.com/aframevr/aframe/issues/5257 This fixes panels disappearing when selecting a-videosphere entity Capture d’écran du 2023-03-14 11-31-44

dmarcos commented 1 year ago

Thanks so much! Do we need to commit the dist?

vincentfretin commented 1 year ago

It's good to have an updated dist on master yes, this way we can use <a-scene inspector="url: https://cdn.jsdelivr.net/gh/aframevr/aframe-inspector@master/dist/aframe-inspector.min.js"> without waiting for a 1.4.2 release.

vincentfretin commented 1 year ago

But your call really. I can remove the commit if you want. And you do the dist and commit it yourself, right after the merge or wait for a new release. Let met know.

dmarcos commented 1 year ago

Problem is that it makes the PRs noisy. Maybe remove for now and can think of setting a build bot like in A-Frame

vincentfretin commented 1 year ago

I removed the dist.

dmarcos commented 1 year ago

Thanks so much!