search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
647 stars 198 forks source link

Fix duplicate entity feature not using the modified value for position/rotation/scale #695

Closed vincentfretin closed 11 months ago

vincentfretin commented 11 months ago

Properly call setAttribute for position, rotation, scale when modifying with the TransformControls, so that entity.flushToDOM() works correctly when duplicating an entity. This fixes #688. See my comment https://github.com/aframevr/aframe-inspector/issues/688#issuecomment-1646632546 for a more detailed explanation of the issue and the proposed fix.

dmarcos commented 11 months ago

Thanks!

vincentfretin commented 11 months ago

@dmarcos You can also close https://github.com/aframevr/aframe/issues/4289 and https://github.com/aframevr/aframe/issues/4084 that were the same issue.