search

aframevr / aframe-inspector

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.
https://aframe.io/aframe-inspector/examples/
MIT License
647 stars 198 forks source link

Fix TextureWidget componentDidUpdate to not crash React UI on aframe 1.6.0 #723

Closed vincentfretin closed 2 days ago

vincentfretin commented 2 weeks ago

This closes #722

vincentfretin commented 1 week ago

Note this PR is okay to be merged, it doesn't crash anymore when you select an entity with a texture, but there is still an issue of changing the texture that's being discussed in #722

vincentfretin commented 1 week ago

Okay, I just verified with aframe master by copying a build manually, the issue of changing the texture on the cube is definitely fixed with both this change and the changes from https://github.com/aframevr/aframe/pull/5544 You can merge @dmarcos

vincentfretin commented 5 days ago

I'm confirming https://github.com/aframevr/aframe/pull/5549 fixes the issue of removing the texture on the cube. @dmarcos can you please merge?

dmarcos commented 2 days ago

Thanks!