age-series / ElectricalAge

Electrical Age (ELN) is a Minecraft Mod offering the ability to perform large-scale in-game electrical simulations.
Other
66 stars 32 forks source link

Add new alarms and sirens #189

Open genestrashcan opened 5 years ago

genestrashcan commented 5 years ago

@jrddunbr -

In a future version lets rework the sirens and alarms, and make new models of them. I will probably do some modeling and produce the sounds for you in the future sometime hopefully.

For sirens we would model them to look like actual sirens you would see on top of a fire department etc.

for sirens i was thinking 3 distinct types to make models of and sounds

Sound of a Good Standard Siren - https://www.youtube.com/watch?v=Tw3L1iteduo

Sound of a good diaphone to use for the Diaphone (use the early 2 tone honks in the video before it changes to single tone around 0:21) - https://www.youtube.com/watch?v=Dluep2RYV7s

Good Sound of a Ktg - https://www.youtube.com/watch?v=bI6hI2WEopM

for alarms we would model them after the alarm you may see in a school used for a fire drill.

simplex 4040

23735074860_0e5f2681a0_b

Sound for the Simplex - https://www.youtube.com/watch?v=uayunq6YEho (Use March Time)

jrddunbr commented 5 years ago

Sirens are a cool thing. Just make sure that we either own the rights to the sounds, or that they are compatibly licensed with the project.

I'll see the models as they come. Upload them here or on the Discor (or do a PR?)

genestrashcan commented 5 years ago

because of how much we're using and what were doing the sounds will be a automatic fair use, or completely public domain. i will try to get permissions from the creators the videos we use sounds for.

genestrashcan commented 5 years ago

Can't wait to see some players get a jumpscare when you get servers with EA working and someone builds a powerplant and puts a gamewell diaphone on top of it and someone else is on the server near the powerplant and it suddenly goes off and their speakers go BLAAAAAAAAAAAARRRR!!! when it starts honking. Thinking of using the sound from this for the diaphone, Turn up your speakers loud to simulate what it is like to be next to a fire company with a diaphone in real life for this video... https://www.youtube.com/watch?v=Dluep2RYV7s

jrddunbr commented 5 years ago

Heh, that's definitely not how fair use works. Ask for permission from the creators.

This is the license they need to approve: https://creativecommons.org/licenses/by-nc-sa/3.0/

jrddunbr commented 5 years ago

This particular video you linked is CC-BY which we can use: https://www.youtube.com/watch?v=Dluep2RYV7s

The rest of them have the standard YouTube license which you can't use, unless you get approval from the authors to allow it to be re-licensed with the license I mentioned above, or similar.

genestrashcan commented 5 years ago

Here's a good one for the regular siren with a CC-BY Licence.

https://www.youtube.com/watch?v=HPixqLqy3Hg

now to try and find one for the Ktg Siren

Ye-Old-Apple commented 4 years ago

Siren Models, Including a STH-10, 3T22, KTG-10, Diaphone Horn, 4040 Fire alarm Sirens.zip I also quickly cut and edited the sound for the Diaphone Horn with the two tone honks.

genestrashcan commented 4 years ago

@Ye-Old-Apple - The exit mouth on the horn on your Gamewell diaphone horn blender model is too wide... Images below showing what model and a proper Gamewell diaphone horn looks like...

bulletin5010_1_print - Copy

bulletin5010_1_print - Copy (2)

bulletin5010_1_print

genestrashcan commented 4 years ago

@Ye-Old-Apple - Diaphone Horn Blend Model with Narrower horn

Gamewell Diaphone Horn Siren.zip

Ye-Old-Apple commented 4 years ago

ok

genestrashcan commented 4 years ago

@Ye-Old-Apple @jrddunbr - Here are the close and distant sounds for the Ktg / Hoopla Siren, I recorded the siren sound myself and had the sound dedicated to the public domain. The distant is a highly edited version of the original in audacity to make it sound far away. Also attached is a distant sound for the Gamewell diaphone too...

You will know why they call it the "Hoopla Siren" after hearing it since it sounds like a bunch of Hoopla / a Dying marching band!

Ktg Siren Sounds.zip

Diaphone_Horn_distant.zip

genestrashcan commented 4 years ago

@jrddunbr - For the Gamewell diaphone, the mechanical clockwork disc system they used to control the honks seen in these videos should be implemented and modeled too. In the second video, the device you saw in the first one (inside the giant red box the bell is wired into) would also honk the Gamewell horn every time the bell rang.

the device you design in-game to send a signal to honk the diaphone should have several mechanical discs that control the honk pattern that can be selected from like the one in real life for different variants of honks when it is set off. (in real life they used different discs for different emergency codes the horn would honk.)

if the honk control mechanism is modeled, I will provide sounds for close and distant versions of the shorter honk that the mechanical disc would make playback for each honk of the horn.

Youtube1

Youtube 2

jrddunbr commented 4 years ago

So loading different models of a disk inside is certainly possible, but it is difficult to sync sounds with rotating objects positions. I have never seen an alarm like that.

genestrashcan commented 4 years ago

@jrddunbr - to make the discs work all you would have to do is mimic the device in the video and make it so the disc would make the device send a signals in a repeating pattern to the diaphone which would make it honk. I will make a shorter version of the honk just for this purpose.

jrddunbr commented 4 years ago

The code is a little different than just telling it to move when the arm moves due to the way the network code works, but we could figure that out.

genestrashcan commented 4 years ago

@jrddunbr - To make it work all we have to do is code the diaphone siren to only play the short one honk when it receives signal voltage through a signal wire, if the voltage is a constant near max voltage in the signal wire that the diaphone is using, the diaphone will only honk once and no longer honk until that voltage has returned to something near 0 and when the voltage was pulsed near-maximum again, the diaphone would honk again. then all you have to do is make the device that would use the rotary discs to push a button in a pattern you would want that would send a short 50v signal down the line connected to the diaphone every time the rotary disc pressed the button that would generate a short voltage pulse on the signal cable to honk the horn.

Here is another video showing the gamewell diaphone ticker system.

Gamewell Diaphone Ticker system

The diaphone should produce a short sound that sounds like this one in this video when pulsed, I am working on editing the current diaphone sound to make a short version that would work well when the system is pulsed.

Falconer NY Gamewell Diaphone

genestrashcan commented 4 years ago

@jrddunbr Here is the sounds for the shorter Pulsed Diaphone

Diaphone Pulse Sound.zip

Ye-Old-Apple commented 4 years ago

this sounds a tad over-complicated for a single horn. I thought the only point of their being different horns/sirens is for the different sounds.

Grissess commented 4 years ago

Indeed, at least transitionally, the "Standard Alarm" can be equipped with a choice, a la IC2. At some later point, the models can be differentiated with shared code (like the lamps).

I can probably take the "transitional" part after the holidays, though I will say: GUI is annoying.

jrddunbr commented 4 years ago

This issue is being closed now since there will be no more feature updates in Electrical Age for Minecraft 1.7.10. If the issue is relevant to 1.12, it will be re-opened there at a later date.

genestrashcan commented 4 years ago

This issue is being closed now since there will be no more feature updates in Electrical Age for Minecraft 1.7.10. If the issue is relevant to 1.12, it will be re-opened there at a later date.

@jrddunbr - Please reopen this + others and label them for Future version development or something.

Closing out all the issues / dumping all the older code / assets that contain WIP code and assets destined for a future version in a program is very bad software development practice.

jrddunbr commented 4 years ago

Don't tell me how to operate an open source community.

I mentioned that we will be re-opening these issues on the new repository. Such issues already have a label for being reopened later (1.12).