search

age-series / ElectricalAge

Electrical Age (ELN) is a Minecraft Mod offering the ability to perform large-scale in-game electrical simulations.
Other
65 stars 30 forks source link

Add terrafirmacraft ores to autominer support list #195

Open netherever opened 4 years ago

netherever commented 4 years ago

Scanner (portable and autominer) don't see TFC ores - therefore, no automaining/ This is sad.

jrddunbr commented 4 years ago

Hmmm. I'm pretty sure those were reported working a while back with the autominer. I have screenshots of a world with a working TFC autominer, at least.

jrddunbr commented 4 years ago

I'll look into it.

netherever commented 4 years ago

It's pretty obviously - ores from tfc very different to vanilla (technicaly - it's block of rock), so scanner see just that.

jrddunbr commented 4 years ago

No, I'm aware of that. I think there's a config or something like that because it worked previously and I haven't made any recent changes to the logic it uses.

netherever commented 4 years ago

No, already checking source - it's just can't work with tfc ores. Obviously - this never tried.

jrddunbr commented 4 years ago

I swear, I've seen it done before. But if you're familiar with the source at this point, feel free to check out 1.15.x stable and submit a pull request for it. I'm sure it's not many lines.

netherever commented 4 years ago

I'm sure it's not many lines.

Wrong. At least need to use tfc api. But let's take it ease. Just take as ore any block with entity - this be enough.

jrddunbr commented 4 years ago

feel free to check out 1.15.x stable and submit a pull request for it.

If you don't submit something, I'll look at it probably this weekend, but I can't guarantee that I'll get it working because I'm pretty busy these days. :/

netherever commented 4 years ago

Done (hope will work)

jrddunbr commented 4 years ago

I'll test things out tonight. I'm concerned about one part of the code, I'm not convinced that it won't just take any tile entity and just mark it as an ore. That would be bad. I'll verify tonight.

netherever commented 4 years ago

It's not right thing, true. But not so bad - work only if set in config, and see (and mined) chest by xray is sort of fun.

jrddunbr commented 4 years ago

This issue is being closed now since there will be no more feature updates in Electrical Age for Minecraft 1.7.10. If the issue is relevant to 1.12, it will be re-opened there at a later date.