search

agens-no / Anymotion

one unified API for animating UIKit, CoreAnimation, POP and your library of choice.
Other
33 stars 9 forks source link

Optional facebook/pop #24

Open zenangst opened 7 years ago

zenangst commented 7 years ago

First of, kudos on a really neat wrapper library around animations. Personally I hope Apple would Sherlock from these kind of libraries in the future. One thing that struck me as a potential improvement to the library is to make the pop animations optional. If you are looking for just a neat wrapper around animation but don't really have or see the need for the entire Facebook/pop framework, it would be neat to be able to opt-out.

PromiseKit has solved this by using extensions, maybe you guys could do the same for pop, or any other framework for that mano. So if you one day have the need, then you just add the extension and BAM! pop is just there. Anyways, looks great. Keep up the good work!

References:

https://github.com/mxcl/PromiseKit#extensions

hfossli commented 7 years ago

Thank you Christoffer! That's a very good idea. I totally agree. That should be a requirement for our 1.0 release.