search

aheckmann / node-ses

An Amazon SES api for nodejs with proper error handling.
http://aheckmann.github.com/node-ses
MIT License
200 stars 37 forks source link

Return errors as JSON using the provided callback. #10

Closed robludwig closed 9 years ago

robludwig commented 9 years ago

Return SES errors as an object. Adds xml2json dependency and requires version bump since it's backwards-incompatible. Update documentation.

robludwig commented 9 years ago

PR title is incorrect: this returns a JS object not a JSON string. Sorry!

markstos commented 9 years ago

Looks good to me.

@aheckmann unless there are objections, I'll release this tomorrow. The major version will be bumped, so current users shouldn't be caught off-guard by the error format change from XML to JavaScript.

aheckmann commented 9 years ago

SGTM

— Sent from Mailbox

On Thu, Nov 6, 2014 at 1:25 PM, Mark Stosberg notifications@github.com wrote:

Looks good to me.

@aheckmann unless there are objections, I'll release this tomorrow. The major version will be bumped, so current users shouldn't be caught off-guard by the error format change from XML to JavaScript.

Reply to this email directly or view it on GitHub: https://github.com/aheckmann/node-ses/pull/10#issuecomment-62054093

markstos commented 9 years ago

@aheckmann I tried to publish a new version to npmjs.org, but I got:

npm ERR! Error: forbidden user: markstos not authorized to modify node-ses

Looks like I need explicit permission to upload new releases there.

aheckmann commented 9 years ago

On Fri, Nov 7, 2014 at 8:04 AM, Mark Stosberg notifications@github.com wrote:

markstos

Ok try it again.

Aaron @aaronheckmann https://twitter.com/#!/aaronheckmann soundcloud.com/ajhecky github.com/aheckmann

markstos commented 9 years ago

Worked. Thanks! https://www.npmjs.org/package/node-ses

On Fri, Nov 7, 2014 at 2:36 PM, Aaron Heckmann notifications@github.com wrote:

On Fri, Nov 7, 2014 at 8:04 AM, Mark Stosberg notifications@github.com wrote:

markstos

Ok try it again.

Aaron @aaronheckmann https://twitter.com/#!/aaronheckmann soundcloud.com/ajhecky github.com/aheckmann

Reply to this email directly or view it on GitHub https://github.com/aheckmann/node-ses/pull/10#issuecomment-62199901.

Mark Stosberg
Senior Systems Engineer
RideAmigos