Closed brozeph closed 9 years ago
Thanks for contribution, we'll take a look. I appreciate that you updated the docs and tests as well as the code.
Hi @markstos and @aheckmann!
Any thoughts or feedback so far that I can address?
Cheers
I've reviewed and merged the PR now. Thanks!
I'll plan to release this later this week after giving @aheckmann some time for final input and new. The proposed release code is now on our master
branch.
To address issue #5 (my own needs required this as well), I implemented the sendRawEmail capability in this excellent module. Additionally, I've added unit tests and upp'd the minor version (set to
v1.1.0
) in thepackage.json
file.A couple other minor adjustments made (note, these are highly opinionated on my part; I completely respect if you wish to deny the PR as a result of any of these):
make jshint
taskjshint
warningssendRawEmail
method to theREADME.md
client.sendemail
toclient.sendEmail
for case consistencyEmail
object to its own file (inlib/email.js
) for easier maintenance