search

aheckmann / node-ses

An Amazon SES api for nodejs with proper error handling.
http://aheckmann.github.com/node-ses
MIT License
200 stars 37 forks source link

Webpack compatibility #32

Closed cspeer closed 8 years ago

cspeer commented 8 years ago

Hi there,

thanks for this awesome module. I only made very simple changes to achieve webpack compatibility. A merge would be highly appreciated :)

Cheers, Chris

markstos commented 8 years ago

I'm merging this because the changes are simple and don't appear to break anything.

However, I understand webpack to be primarily a bundler for browsers. This module doesn't make sense to use in a browser because it requires authentication which should be protected by being server-side.

cspeer commented 8 years ago

Thanks & Agreed. However, I've lately seen webpack being used in a backend-only environments, for example with AWS Lambda, which I am using webpack for as well.

markstos commented 8 years ago

I don't have time to cut a release today, but you can use the merged code with the assurance it is forward-compatible with the next release.

On Mon, Aug 8, 2016 at 3:41 AM, Christopher Speer notifications@github.com wrote:

Thanks & Agreed. However, I've lately seen webpack being used in a backend-only environment, for example with AWS Lambda, which I am using webpack for as well.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/aheckmann/node-ses/pull/32#issuecomment-238163302, or mute the thread https://github.com/notifications/unsubscribe-auth/AABk5YcEtxIUrvzilmBQHTOSdOHjjgAVks5qdt2ygaJpZM4JeY1b .

Mark Stosberg
Senior Systems Engineer
RideAmigos