search

aheckmann / node-ses

DEPRECATED
MIT License
200 stars 37 forks source link

Add SES configuration set and message tag handling #53

Closed xppppp closed 5 years ago

xppppp commented 5 years ago

For issue #47... hope this helps!

justinwaite commented 5 years ago

Any movement on this? Looking forward to using it for a project. Happy to contribute in any way.

markstos commented 5 years ago

@xppppp @jdeanwaite @tsudharsanprdxn @fscardua

Thanks for the nudges and PR for this. Support for configuration sets was released today in version 2.2.0.

As I looked into Configuration Sets, I found this was really I feature I could use myself as well. So thanks!

I also wanted to say that I'd welcome a PR to support promises. This could either be done as an alternate interface or as a breaking change. I think I'd prefer to ahead and make a breaking change, even if I have to update my own code. Using this module with async/await would be nice.

Currently our callbacks return three arguments: (err, data, res), which doesn't map cleanly to promises which only return one value. The refactor will need to address this.

If you are interested in contributing this, announce here https://github.com/aheckmann/node-ses/issues/54 that you are starting work on that PR.