search

aheckmann / node-ses

An Amazon SES api for nodejs with proper error handling.
http://aheckmann.github.com/node-ses
MIT License
201 stars 37 forks source link

Revert JSON parsing #62

Closed markstos closed 4 years ago

markstos commented 4 years ago

Fixes #61

markstos commented 4 years ago

@epegzz @MaheshCasiraghi Could you test this branch before I release it?

It reverts the XML -> JSON change plus some other clean-ups.

markstos commented 4 years ago

Thanks for the testing @epegzz !

markstos commented 4 years ago

I'm back from a day off and will get this release out today.

On Fri, May 1, 2020 at 6:58 AM Daniel Schäfer notifications@github.com wrote:

@epegzz commented on this pull request.

In .jshintrc https://github.com/aheckmann/node-ses/pull/62#discussion_r418499681:

@@ -1,4 +1,5 @@ {

  • "esversion": 6, "bitwise" : true,

Oh, just thought it would make sense to stay consistent, and not to change the indentation on a per line basis. I don't really care about the linting otherwise :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aheckmann/node-ses/pull/62#discussion_r418499681, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGJZKQJFBLMEDPAWY5C4LRPKTM7ANCNFSM4MT6DGUA .

-- Mark Stosberg Director of Systems and Security RideAmigos

markstos commented 4 years ago

Published today in v3.0.2.

epegzz commented 4 years ago

Great, works! 👌