New Desing Slider Gallery Images.

ahmedkaludi / accelerated-mobile-pages

Automatically add Accelerated Mobile Pages (AMP Project) functionality on your WordPress.

http://ampforwp.com

Other

176 stars 96 forks source link

New Desing Slider Gallery Images. #2248

Open mdkaleem95 opened 6 years ago

mdkaleem95 commented 6 years ago

Ref: https://secure.helpscout.net/conversation/592350115/27246?folderId=1914712

merajali294 commented 6 years ago

https://www.swipty.dk

raju-jeelaga commented 6 years ago

Pending Issues

[x] Slider design 3 Dots Functionality not working properly [Ajeet]
[x] Slider Desing 4 Required Filed is not working [Ajeet].
[x] Crafting is pending for Slider Mod Design 3 and 4 [ Raju, Ahmed]
[x] Screenshots of Desing3 and Desing 4.[Raju]

raju-jeelaga commented 6 years ago

[x] Slider Design 4 Html and css added and Fields are created and connected to option and pgb 016648b

ahmedkaludi commented 6 years ago

REVIEW:

[x] Change the order "Layout" to second position: http://take.ms/DaWnO

ahmedkaludi commented 6 years ago

Let's change the name as per our discussion. Gallery will be "Logo" Slider will be "Gallery / Slider"

ahmedkaludi commented 6 years ago

REVIEW

[x] Let's order the module names correctly: http://take.ms/3zYcc

ahmedkaludi commented 6 years ago

Review

[x] Arrow doesn't look good: http://take.ms/DhB1L - From D1 - D3, Use the arrow we have in the menu http://take.ms/Szk2q - and for the D4, we have the icon font.

MARQAS commented 5 years ago

Make sure to add Convert AMP to WP code from https://github.com/ahmedkaludi/accelerated-mobile-pages/issues/2771 while merging this ticket.

raju-jeelaga commented 4 years ago

It is issue with @media query merger ampforwp_pb_autoCompileLess this functions preg_replace creating some issue to combine @media queries for now i change the @media screen size 768px to 769px after fix this issue #3797 need to add the proper screen size.

raju-jeelaga commented 4 years ago

[x] font awesome [Custon code with CSS is added for angle bracket ]
[x] responsive of the First new slider (http://localhost/ampforwp/wp-content/plugins/accelerated-mobile-pages//images/slider-3.png)
[x] D2 of slider, if img is not present, then validation error
[x] box shadow for d2 slider
[x] d2 slider looks strange background color in Design one

raju-jeelaga commented 4 years ago

Slider Design 1 Responsive is not looking good because of Media queries are removing automatically when merging. Note: We need to push the current ticket based on this #3797 [This ticket will fix the media query problem]

raju-jeelaga commented 4 years ago

Note: For Now Testing purpose i change the media screen sizes and push the code, once this #3797 ticket is fix, then need to add the proper media screen sizes.