Open pegazee opened 5 years ago
There is another user is asking.
REF:https://secure.helpscout.net/conversation/889281410/71927?folderId=3008055
Notice: Undefined variable: amp_permalink in C:\xampp2\htdocs\wp\wp-content\plugins\accelerated-mobile-pages\pagebuilder\modules\social-share-module.php on line 31 and also please change the function name
Call to undefined function ampforwp_sanitize_twitter_title - in plugins\accelerated-mobile-pages\pagebuilder\modules\social-share-module.php:25
UI improvement required in the backend: https://take.ms/bysyj
Output not looking good as well: https://take.ms/xj2UU
Function name is not correct. https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/afddd954a2cc9e8dde8fd1f3b282eaf8fde41b73#diff-0d00031844fc2daf2d2f57963ec5003fR5
UI improvement required in the backend: ------------------ After Discussion with @ahmedkaludi, he told me that checkbox option is fine and remove the yes Label.
Output not looking good as well: --------------underline is removed and Facebook like button styling problem will be fixed in this ticket #4043
Function name is not correct: ------------- Function name properly added.
ready to merge.
The social sharing buttons only appear in pages when edited by “custom AMP editor” but not by “AMP page builder”. We need to add a social icon module for this scenario.
ref: https://wordpress.org/support/topic/social-share-button-2/