Downstream deps causing issues during postinstall for scripts

ai / size-limit

Calculate the real cost to run your JS app or lib to keep good performance. Show error in pull request if the cost exceeds the limit.

MIT License

6.52k stars 1.82k forks source link

Downstream deps causing issues during postinstall for scripts #280

Closed rmarkins-godaddy closed 2 years ago

rmarkins-godaddy commented 2 years ago

the estimo package which depends upon puppeteer-core is causing issues when doing an npm install as the script fails due to their exports package.json change. Here are both issues I have filed

https://github.com/mbalabash/estimo/issues/36

https://github.com/puppeteer/puppeteer/issues/7986

ai commented 2 years ago

What version we should lock?

rmarkins-godaddy commented 2 years ago

@ai 13.2.0 should be good enough for puppeteer

ai commented 2 years ago

I can lock only estimo version. If you know a solution, please send PR.

rmarkins-godaddy commented 2 years ago

@ai looks like puppeteer has reverted their exports change and published a new patch for this so downstream estimo might be unblocked for now. Closing this issue unless something else comes up