Incorrect config parsing

[JounQin]

https://github.com/ai/size-limit/blob/7461f32cddc403fe8ee6db4f8d43c9a76bfc9c52/packages/size-limit/run.js#L67-L72

It only looks up for package.json for plugins, and throws if no plugin found from package.json.

[ai]

What logic do you expect?

[JounQin]

https://github.com/ai/size-limit#config

@ai

[ai]

https://github.com/ai/size-limit#config

This config is for limits.

It is not for plugins.

Our API is that Size Limit takes plugins from package.json.

Why do you need plugins in the config?

[JounQin]

Size Limits supports three ways to define config.

I don't quite understand

This config is for limits.

It is not for plugins.

How should we define plugins in package.json?

Why do you need plugins in the config?

I'm trying to use modifyWebpackConfig.

[JounQin]

Besides, I want to use modifyWebpackConfig because I want to external all node modules from size calculation.

It seems no esbuild config to set.

[ai]

I don't quite understand

It means 3 different file names .size-limit.json or .size-limit.js or size-limit section in package.json

How should we define plugins in package.json?

Just add them to devDependencies.

For instance by:

npm install --save-dev @size-limit/webpack

[ai]

I am closing this issue since it is a question, not an issue.

Feel free to continue discussion with questions.

[JounQin]

I think it could be very confusing from current documentation.

[ai]

Please send PR if you know how to improve it

[JounQin]

@ai Please review #290