search

ai / size-limit

Calculate the real cost to run your JS app or lib to keep good performance. Show error in pull request if the cost exceeds the limit.
MIT License
6.48k stars 1.82k forks source link

chore: loose strictness of peer dependency requirement of `tslib` #327

Closed mcmxcdev closed 1 year ago

mcmxcdev commented 1 year ago

Still no clue where the peer dependency requirement comes from, I don't see it defined in either size-limit-node-esbuild or size-limit itself.

Now users could update to tslib 2.5.3 at least to satisfy and match the dependency requirement.

Closes https://github.com/ai/size-limit/issues/326

ai commented 1 year ago

It comes from package.json (in project’s root) and fixtures/plugins/package.json

mcmxcdev commented 1 year ago

It comes from package.json (in project’s root) and fixtures/plugins/package.json

That's where size-limit-node-esbuild is installed yes, but not where peerDependencies: { "tslib": "2.5.0" } is coming from.

I think I figured out what the actual issue is, read more: https://github.com/ai/size-limit/pull/327#issuecomment-1585048284

ai commented 1 year ago

Have no idea. The lock file which you fixed is not in any npm package.