search

ai / size-limit

Calculate the real cost to run your JS app or lib to keep good performance. Show error in pull request if the cost exceeds the limit.
MIT License
6.48k stars 1.82k forks source link

fix: use dynamic `import` directly without `require.resolve` #345

Closed JounQin closed 8 months ago

JounQin commented 8 months ago

close #336 close #344

JounQin commented 8 months ago
image

Some entries are not exported, should we export then? Or we still use the absolute path hack?

@ai

ai commented 8 months ago

Some entries are not exported, should we export then?

I think we should not need @size-limit/esbuild/convert-config export at all. This is very simple function. Just replace it.

ai commented 8 months ago

If you need some bigger function, I can export it.

ai commented 8 months ago

Thanks. Released in 10.0.3.

JounQin commented 8 months ago

Ah, I just realized that was my plugin throwing, actually the newer versions are not using the unexported entries now. So we'd better upgrade the test case dep versions.