ai / size-limit

Calculate the real cost to run your JS app or lib to keep good performance. Show error in pull request if the cost exceeds the limit.
MIT License
6.48k stars 1.82k forks source link

Add explicit `packageManager` field to `package.json` #365

Closed aryaemami59 closed 3 weeks ago

aryaemami59 commented 1 month ago

This PR:

ai commented 1 month ago

I have 50+ open source projects, it will be very hard for me keep up to date to version of pnpm in package.json manually in every project.

Do you have any reason why this key is important to spend more time on maintenance?

aryaemami59 commented 1 month ago

Mostly because corepack needs it, but there are some other reasons:

I understand if you're not on board with this, and if not, just say so and I'll go ahead and close the PR, but if you're okay with it, I can help put up PRs for the rest of your libraries (yes all 50+).

ai commented 1 month ago

I really afraid of locking the exact version of pnpm.

What if there is old project with 9.1.1 and new developer come with 9.2? Will it require too many versions of pnpm on developers machine in corepack?

aryaemami59 commented 1 month ago

In that case, they will already have version 9.1.1 on their machine, since corepack caches the old versions on the global registry, and will not remove them unless they call corepack cache clear manually.

ai commented 3 weeks ago

I decided to not use it right now. It is better to use the latest pnpm.