aikaterna / gobcog

RPG Adventure Cog for Red v3
44 stars 68 forks source link

[Question] Cart rolling items correctly? #373

Closed Prequarantine closed 2 years ago

Prequarantine commented 2 years ago

Complete these first

Expected Behavior

The cart should maybe have rare items or better on it occasionally? It seems like it should be rolling these items based on the code, but it simply does not on our server.

Current Behavior

Summoning the cart by chatting normally results in 0 rare or better items being present on the cart. All items are normal quality. I am unsure if this is intentional or not. All players are currently rebirth 1 or rebirth 2 now, having just started playing a bit ago

Possible Solution

None if intended cart behavior. Making it so the cart can spawn better items otherwise.

Steps to Reproduce

  1. Chat after cart cd is up, causing the cart to spawn.
  2. See that the cart has no rare items at all.

Context (Environment)

Oddly despite having done plenty of adventures, my group has seen almost no rare items (EDIT: Upon checking, we have zero logs of any rare chests at all, but this is probably just bad luck?), and with no way of getting rare items aside from pets, we were just curious.

Detailed Description

None necessary. We just don't know how it works and wanted to know if it was really working correctly. I am very, very sorry if this is not a bug and it is working correctly. I wanted to just join the Discord to ask, but the link is invalid for some reason, and I could not find another server to ask.

Possible Implementation

None necessary. We just don't know how it works and wanted to know if it was really working correctly.

Prequarantine commented 2 years ago

Just tested and figured out the fix. lines need "self," before rarity string. for example,

item = await self._genitem(self, "rare")

instead of

item = await self._genitem("rare")

This bricks our carts in a wholly new and exciting way as they are almost entirely non-equippable items, but is a vast improvement over getting nothing but commons.

aikaterna commented 2 years ago

Fixed in https://github.com/aikaterna/gobcog/commit/7373b19a5ae756719c2db9efd58c8afc0e64e73b

Close guess, but it needed ctx. Thanks for the report.