aikaterna / gobcog

RPG Adventure Cog for Red v3
44 stars 68 forks source link

[Command Bug] Insight shows false transcended mob #391

Closed Dark-lame closed 2 years ago

Dark-lame commented 2 years ago

Complete these first

Command name

insight

Expected Behavior

When a user runs the insight command, if the mob is Transcended it should look something like this: image Or with the (Transcended) line near the end of the insight response: image

Current Behavior

adventure version 3.5.3 A special case has occurred: image There is no "Transcended" in the mob name, but the later (Transcended) is there. The raid result is as follows: image It was not a real transcended mob.

Possible Solution

Possible solution would be either remove the (Transcended) near the end of the first string to remove the redundancy, if its a separate function, or if it's the highest/most accurate insight one can get.

Steps to Reproduce

  1. switch to psychic & hardmode if not already
  2. pray to RNJesus that you land a transcended mob
  3. Check response if it matches above scenario

Context (Environment)

Has not resulted in any crashes or bot-error response, so it's a QoL fix. However, it would a significant one in case this happens again.

Detailed Description

aikaterna commented 2 years ago

What's the problem? Insight does do this if the psychic rolls a high enough value to expose all that information about the mob.

Dark-lame commented 2 years ago

sorry aika i hit enter before i finished. almost done

aikaterna commented 2 years ago

Thanks for chatting about it in the support server, for reference for myself for later: https://discord.com/channels/154659242253484033/403297256104787978/991160453248069742

Dark-lame commented 2 years ago

as of update 3.5.4: issue is still prevalent: image

This may be unrelated, but since we updated to 3.5.4, no transcended mobs have spawned.
image

For a server of our size and activity, getting no transcended mob for nearly 2 weeks is very unusual.