Insight rounds up on HP when it doesn't need to be rounded.
Complete these first
[ ] I confirm that I am the owner of the bot running Adventure.
[ ] I confirm that I have not modified the source code of Adventure.
[x] I'm an Adventure user but not the bot owner.
[x] I confirm that I have checked the issue tracker and a this bug hasn't been reported already.
Command name
insight
Expected Behavior
When a user does insight, it should accurately give information based on the roll. Resulting insight HP should be rounded up when necessary in accordance with the mob HP decimal.
Current Behavior
adventure version 3.5.3
The insight command rounded up unnecessarily.
Resulting mob HP:
The mob HP's are 1 less than the insighted HP's.
Possible Solution
Possible solution could be to check where the decimals are coming from? Could be slight miscalculations pertaining to modifiers and past raid results. Or something got cast somewhere incorrectly.
Steps to Reproduce
Change to hardmode and psychic if not already
Keep doing insight command until rounding error is found
Context (Environment)
Has not resulted in bot crash or error logs, so this would be a QoL fix. However this is a very minor one with it only being a 1 hp difference, so not at all high priority.
Insight rounds up on HP when it doesn't need to be rounded.
Complete these first
Command name
insight
Expected Behavior
When a user does insight, it should accurately give information based on the roll. Resulting insight HP should be rounded up when necessary in accordance with the mob HP decimal.
Current Behavior
adventure version 3.5.3 The insight command rounded up unnecessarily.
Resulting mob HP:
The mob HP's are 1 less than the insighted HP's.
Possible Solution
Possible solution could be to check where the decimals are coming from? Could be slight miscalculations pertaining to modifiers and past raid results. Or something got cast somewhere incorrectly.
Steps to Reproduce
Context (Environment)
Has not resulted in bot crash or error logs, so this would be a QoL fix. However this is a very minor one with it only being a 1 hp difference, so not at all high priority.
Detailed Description
Possible Implementation