search

airdcpp / airdcpp-windows

http://www.airdcpp.net
GNU General Public License v3.0
82 stars 19 forks source link

Crash when sending a command at the same time the user logged out #125

Open Sopor opened 2 months ago

Sopor commented 2 months ago

Prerequisites

Describe the issue

I was going to perform a nick change and at the same time i did that the user logged out and AirDC crashed.

Expected behavior

It shouldn't have crashed!

Actual behavior

It crached!

Steps to reproduce the behavior if needed

No response

Screenshot

No response

Crash log

Code: c0000005 ( Access violation )
Version: AirDC++ 4.22b-3-g1b7129 x64
Build: 4724
Major: 6
Minor: 2
Build: 9200
SP: 0
Type: 1
Time: 2024-07-22 20:21:40
TTH: FHZ2U2I4YOAFKFHCRSLMNBCFLEWMXCESBLUXVAY

c:\Projects\airdcpp-windows\airdcpp\airdcpp\User.cpp(128): dcpp::Identity::getParams
c:\Projects\airdcpp-windows\windows\RichTextBox.cpp(1456): RichTextBox::runUserCommand
c:\Projects\airdcpp-windows\windows\ShellContextMenu.cpp(68): ShellMenu::open
c:\Projects\airdcpp-windows\windows\RichTextBox.cpp(1017): RichTextBox::onContextMenu
c:\Projects\airdcpp-windows\windows\RichTextBox.h(50): RichTextBox::ProcessWindowMessage
c:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.40.33807\atlmfc\include\atlwin.h(4616): ATL::CContainedWindowT<ATL::CWindow=0x96F62F18,ATL::CWinTraits<1442840576=0x00007FFF,0> >::WindowProc
atlthunk!0x7FFF96F62F18: ?
USER32!0x7FFFC785EF5C: CallWindowProcW
USER32!0x7FFFC785E9DE: CallWindowProcW
c:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.40.33807\atlmfc\include\atlwin.h(4621): ATL::CContainedWindowT<ATL::CWindow=0x96F62EE8,ATL::CWinTraits<1442840576=0x00007FFF,0> >::WindowProc
atlthunk!0x7FFF96F62EE8: ?
USER32!0x7FFFC785EF5C: CallWindowProcW
USER32!0x7FFFC785DFBB: SendMessageW
USER32!0x7FFFC788F7AE: SetWindowsHookExAW
USER32!0x7FFFC785C90D: GetWindowTextW
MSFTEDIT!0x7FFF9749A9E4: RichEditWndProc
USER32!0x7FFFC785EF5C: CallWindowProcW
USER32!0x7FFFC785E9DE: CallWindowProcW
c:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.40.33807\atlmfc\include\atlwin.h(4621): ATL::CContainedWindowT<ATL::CWindow=0x96F62F18,ATL::CWinTraits<1442840576=0x00007FFF,0> >::WindowProc
atlthunk!0x7FFF96F62F18: ?
USER32!0x7FFFC785EF5C: CallWindowProcW
USER32!0x7FFFC785E9DE: CallWindowProcW
c:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.40.33807\atlmfc\include\atlwin.h(4621): ATL::CContainedWindowT<ATL::CWindow=0x96F62EE8,ATL::CWinTraits<1442840576=0x00007FFF,0> >::WindowProc
atlthunk!0x7FFF96F62EE8: ?
USER32!0x7FFFC785EF5C: CallWindowProcW
USER32!0x7FFFC785E684: DispatchMessageW
c:\Projects\airdcpp-windows\windows\WTL\atlapp.h(666): WTL::CMessageLoop::Run
c:\Projects\airdcpp-windows\windows\WinClient.cpp(458): WinClient::run
c:\Projects\airdcpp-windows\windows\main.cpp(337): wWinMain
D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(288): __scrt_common_main_seh
KERNEL32!0x7FFFC8B97374: BaseThreadInitThunk
ntdll!0x7FFFC8EFCC91: RtlUserThreadStart

AirDC++ version and architecture (x86 or x64)

4.22b-3-g1b7129

Operating System name, version and architecture

Windows 10 22H2 x64

Additional information

No response

maksis commented 2 months ago

Are you able to reproduce this?

Sopor commented 2 months ago

I have tried, but it is very hard to try to reproduce it when you need to logout and send the command at the same time.

So, the answer is no.