search

airdcpp / airdcpp-windows

http://www.airdcpp.net
GNU General Public License v3.0
82 stars 19 forks source link

Checked Shared directories are not saved after closing the Settings window #147

Open Korb opened 1 week ago

Korb commented 1 week ago

Prerequisites

Describe the issue

Subj.

Expected behavior

By checking the boxes for sharing and clicking the OK button in the Settings window, the indexing process of the specified folders begins, the size of the shared files increases, and when I reopen the Settings window on the Sharing tab, I will be able to see the checkboxes in the same places where I previously put them.

Actual behavior

After clicking OK nothing happens, a

Please wait while AirDC++ indexes your files (they won't be shared until they've been indexed)... Done Statistics -.-- files/h, 0 files left -.—B/s, 0 B left -:-:-left

is displayed in the "Creating file index..." window.

Shared files size: 0 bytes

Steps to reproduce the behavior (if applicable)

  1. Download and unzip airdcpp_4.21_x64.7z
  2. Run AirDC.exe and go through all the steps of the Settings Wizard
  3. Go to Settings and mark several folders on local drives other than the drive from which the application was launched for sharing.
  4. Close the Settings window with the OK button and open it again.
  5. Make sure that the folders marked in the third step are displayed unmarked.

Screenshot/video

No response

Crash/hang log

No response

AirDC++ version and architecture (x86 or x64)

4.21 x64

Operating System name, version and architecture

Windows 10.0.19045.5011

Additional information

No response

Sopor commented 1 week ago

Where have you extracted the 7z file?

When running portable version you can't put AirDC in a folder you need Administrator rights, like Program, Program files, Program files (x86) etc.

You also need to create a folder e.g. AirDC and extract the files into that folder.

Korb commented 1 week ago

Where have you extracted the 7z file?

D:\AirDC++\

Sopor commented 1 week ago

And you don't need admin rights to write to that drive?

Korb commented 6 days ago

And you don't need admin rights to write to that drive?

Nope.

Korb commented 6 days ago

The problem was solved by the following sequence of actions (or part of it, or something else that coincided in time):

  1. Close AirDC++.
  2. Rename the folder from AirDC++ to AirDC.
  3. Launch AirDC++.
  4. Add a folder for sharing (now after clicking on the checkbox a window will appear

Virtual name Name under which the others see the directory Add also in the following profiles Default (Default) Select all OK / Cancel

(this window did not appear before, the checkbox was simply placed without a request).

  1. Close AirDC++.
  2. Rename the folder from AirDC to AirDC++.
  3. Launch AirDC++.

Can the Issue be closed as it is not planned?

💡 Upd. I think I figured out what the error is. Try checking the folder boxes in Settings not with a mouse click, but with the space bar. In this case, the checkbox is checked without asking for a profile, and is not saved when the Settings window is closed. I believe this is precisely the issue - how exactly the user marks the folders for sharing (using the mouse or using the keyboard). Personally, I prefer keyboard navigation in this case, and it would not have occurred to me that there is a difference between using the mouse or the keyboard.

Sopor commented 6 days ago

You have the Show directory tree enabled? I never have it enable because you can't enable incoming directory if Show directory tree is enabled and you can remove drives that no longer exists either.

I can recreate your issue in 4.22b-122 with Show directory tree enabled when using the keyboard to navigate and select directories with the keyboard.

That should be fixed or what do you think @maksis ?

Korb commented 5 days ago

You have the Show directory tree enabled?

Yes.