RoLex
commented
2 years ago @Kcchouette
Sure, but "secure" means generally TLS encrypted/secure address. Because a hub can have both secure and unsecure address. My hublist for example, always provides "secure" attribute in XML, and it always means that address in this field is secure/TLS encrypted, else "secure" is empty, meaning that hub doesn't have a secure address, or atleast hublist doesn't know about it yet.
I didn't choose word "secure" from the the air, I did actually look up how a secure/TLS encrypted address is normally called in different protocols, here is example for HTTPS: https://en.wikipedia.org/wiki/HTTPS (therefore "S" in the end of HTTPS or NMDCS).
Another thing why "secure" is separate from "address" - is because some clients don't support TLS at all, it would be a great mistake to set "address" to a secure/TLS encrypted address. Example is DC++ 0.870 and below. In next DC++ version I have already added support for secure connections between clients and hubs.
Do you agree? If you don't, sure, we can rename it to what ever you like. The point of this feature is to allow users to actually use the secure/TLS encrypted connection between client and the hub in the first place, hence all the anti P2P things going around at the ISP level.
maksis
Kcchouette
I don't really understand what mean the "Secure" attribute, you can instead put the "nmdcs" / "adcs" (you already do it for adcs in true) address directly in the "Address" attribute, can't you?