airdcpp / airdcpp-windows

http://www.airdcpp.net
GNU General Public License v3.0
80 stars 19 forks source link

[4.12b] Release names/URLs not being recognized properly (color, context menu, etc.) #78

Closed ryehamstrawberry closed 1 year ago

ryehamstrawberry commented 1 year ago

As of today, compiling the latest source code produces a build that seems to label the right-click context menu of release names found in chat as "Text" rather than the "Release" menu found in v4.11 stable.

ryehamstrawberry commented 1 year ago

Note: I use the Kungligt theme, which has text color for release names/URLs set to white. The latest beta I compiled seems to treat release names as non-links as most of them are no longer colored white, but rather dark purple, which is the color set to highlight non-clickable release names.

The highlight entry for these non-links is: $Re:(?# release)(?i)(?:(?:\S+.\S*(?:dvdrip|xvid|dvdr|svcd|vcd|rip|hdtv|x264|bluray|bdr|flac)\S?-\S+)|\S+-\d{4}-\S+) Underline enabled Context: Chat Color: Dark purple

Since non-clickable links are much less common than typical Release_Name-Formats, I have changed the above highlight entry color from dark purple to white, which is the color all release names/URLs should have been colored. While this is a simple workaround, now all non-clickable release names are colored white as well, when previously they were distinguished with their own dark purple color.

For example: guy_artst-test_name_here-(ZZZ000)-WEB-2022-GRPNAME The way Kungligt theme is setup to highlight this release name in dark purple, indicating it cannot be double clicked. Although, release names using typical Title Casing like Guy_Artst-Test_Name_Here-(ZZZ000)-WEB-2022-GRPNAME should be displayed in white, indicating they can be clicked and the right-click "Release" menu is available. There seems to be some issue with how release names are identified since all release names are displayed in dark purple, despite having my main URL color set as white.

I know this might seem like a theme issue, but even using the default theme indicates there must be something that's changed between v4.11 stable and the latest beta code since modifying Settings>Appearance>Colors & fonts>URL color does not seem to set release name colors properly. The only workaround seems to be modifying the previously mentioned highlight entry color, which is fine for most cases, but unfortunately this prevents non-clickable release names from being highlighted in dark purple as was intended.

Let me know if you need further explanation.