airdcpp / airdcpp-windows

http://www.airdcpp.net
GNU General Public License v3.0
80 stars 19 forks source link

🐛 [Bug]: %[engname] returns localized name #88

Closed RoLex closed 1 year ago

RoLex commented 1 year ago

Prerequisites

Describe the issue

%[engname] parameter returns localized name instead of english name according to:

https://github.com/airdcpp/airdcpp-windows/blob/master/airdcpp/airdcpp/GeoIP.cpp#L102

Expected behavior

Should be:

params["engname"] = [&] { return parseData(res, "country", "names", "en", NULL); };

Actual behavior

Currently is:

params["engname"] = [&] { return parseData(res, "country", "names", language.c_str(), NULL); };

Steps to reproduce the behavior if needed

No response

Screenshot

No response

Crash log

No response

AirDC++ version and architecture (x86 or x64)

4.20

Operating System name, version and architecture

Windows 11 x64

Additional information

No response