airgap-it / beacon-android-sdk

The beacon sdk allows Android developers of dApps and wallets on Tezos to implement the wallet interaction standard tzip-10.
https://walletbeacon.io
MIT License
10 stars 8 forks source link

Ktor versions conflict #14

Closed Deneath closed 1 year ago

Deneath commented 1 year ago

Bug Report

Current Behavior

In my project I use the third-party library which uses a Ktor version 2.2. But there is Ktor version 1.6 in beacon sdk. As soon as I start using the beacon related classes, my app crashes. exception-logs.txt

If I remove this third party library (with Ktor 2.2), everything works fine. But we dont need to remove it - we need to use both libraries. So I suggest to upgrade beacon sdk to use Ktor version 2.2 migration guide

Expected Behavior

Beacon sdk uses Ktor 2.2. There is no versions conflict

How to Reproduce?

You can add a dependency that uses a Ktor 2.2 to the beacon sample project

Environment

jsamol commented 1 year ago

Hi @Deneath! Thanks for pointing this out. We've just released v3.2.4 with Ktor version updated to the latest (v2.2.3), I hope this solves your problem.

Deneath commented 1 year ago

Brilliant! Everything works as expected. Thank you @jsamol for quick reaction.