search

airvolute / dcs-deploy

GNU General Public License v3.0
1 stars 0 forks source link

Bug while flashing Orin NX 8gb version #26

Closed eMrazSVK closed 1 month ago

eMrazSVK commented 3 months ago

This is an obvious bug. When running:

python3 dcs_deploy.py flash orin_nx_8gb 512 2.0 nvme full

Following error is thrown:

Traceback (most recent call last):
  File "dcs_deploy.py", line 849, in <module>
    dcs_deploy.run()
  File "dcs_deploy.py", line 843, in run
    self.airvolute_flash()
  File "dcs_deploy.py", line 834, in airvolute_flash
    self.flash()
  File "dcs_deploy.py", line 810, in flash
    ret = self.generate_images()
  File "dcs_deploy.py", line 801, in generate_images
    f"-c {self.ext_partition_layout} {self.orin_options} --showlogs {self.board_name} {self.rootdev}", print_command=True)
AttributeError: 'DcsDeploy' object has no attribute 'orin_options'

I think it's obvious, because somehow, there is self.orin_options variable setter missing here: https://github.com/airvolute/dcs-deploy/blob/main/dcs_deploy.py#L729-L730

So I think easy fix should be adding this line below:

self.orin_options = '--network usb0 -p "-c bootloader/t186ref/cfg/flash_t234_qspi.xml --no-systemimg"'

Which appears this "option" is the same for all Orin devices.

@MartinSedlacek