search

ajam / pulp

A vivacious viewer for web comics.
http://ajam.github.io/pulp
MIT License
89 stars 17 forks source link

left/right mask not showing up on vertical panels #33

Closed jacqui closed 9 years ago

jacqui commented 9 years ago

I was trying to figure out why some of the panels weren't masked correctly in the latest page art I got from our artist - basically, the transitions work but you can see all the surrounding stuff on the right and left of each panel from one transition to the next.

Spelunking in the CSS led me to find that the z-index on the #left-mask and #right-mask divs wasn't high enough. I don't full get why this is, but I know that when I changed the z-index value from '999' to '9999' (yo, add a 9 to it) the masks and panels looked great.

This is only an issue for me now with vertical not horizontal panels. I will submit a pull request once I test it out a bit more, but I wanted to log it as an issue. Figured you'd have a better understanding of what's going on here than I do.

One more thing: pulp & pulp-viewer are amazing and everyone at BBC News (myself included) LOVES it. So... thank you :)

mhkeller commented 9 years ago

Thanks Jacqui! AKA code spelunking extraordinaire. code-spelunking

I think the pull request has to include "(yo, add a 9 to it)". We might want to throw a 9 on #btns too so they remain on top of everything and don't get masked. The masks and buttons shouldn't ever really coexist, however, since one is mobile and the other desktop but #34 might change this in the future.