search

ajam / pulp

A vivacious viewer for web comics.
http://ajam.github.io/pulp
MIT License
89 stars 17 forks source link

[new-zoom-modes] `desktop-hover` mode on cover bookend needs polishing #40

Closed mhkeller closed 8 years ago

mhkeller commented 9 years ago

The double size of cover is causing issues on bookend cover since the hover area doesn't correspond to the image size. A possible solution might be to set the div width to the image width on load after images .onDone.

mhkeller commented 9 years ago

This is kind of working now but the mouseenter and exits don't seem to be reliably firing. Relevant code: https://github.com/ajam/pulp/blob/51a703f9e57d479e966f1f1c6a1d1b8af54f83f7/js/app.js#L673-L735

The easy solution for this whole thing is to make the div the width of the cover image, as thought above. The problem with that is that the page div needs to be double width wide so that when you click next, it is wide enough to not clip out the incoming changes. hmm maybe instead of dynamically changing the width, there was a state based css rule like 

body[data-state="page-change"] 
    .page
        width full-width-or-something
mhkeller commented 8 years ago

This is now implemented on [desktop-hover(]https://github.com/ajam/pulp/tree/desktop-hover) branch and will merge to master