search

ajam / pulp

A vivacious viewer for web comics.
http://ajam.github.io/pulp
MIT License
89 stars 17 forks source link

Better page loading image #9

Closed mhkeller closed 10 years ago

mhkeller commented 10 years ago

It's currently set up to display placeholder.jpg until lazy loading kicks in.

1) It should display a better image than it is currently 2) It would be nice if it displayed something with a spinner gif animation since those are nice and give more feedback that the page is doing something.

If the placeholder image is going to be a gif, however, then either jpg needs to be hardcoded into the template (which is fine for now) but it should be specified in pulp-press what format your images are in.

mhkeller commented 10 years ago

The gif is now being loaded as base64 encoding to avoid different file extensions: https://github.com/ajam/pulp/commit/00f0058404d9c3cfc09a77381b8bb799ec2c7500

The extension is still customizable though and now in settings: https://github.com/ajam/pulp/commit/25f4b9082f53370aa66ca641c8c6c7ccd6599bf0