akamai / esi-test-server-docker

A dockerized version of Akamai's Edge Side Includes Test Server (ETS).
32 stars 6 forks source link

Add --remote-on-host configuration flag #6

Open webuniverseio opened 6 years ago

webuniverseio commented 6 years ago

Hi, Since primary purpose for ETS is to be used for development environments it would be nice to improve how to connect sites running on host with ETS. There is a way to modify hosts by using --add-host but you need to know what ip address will be assigned to host when container is running. For this purpose docker added docker.host.internal which you can ping to get host machine ip. I'm proposing to add --remote-on-host flag which will tell ETS to ping docker.host.internal, get host machine ip and add hostname to hosts file. For example:

docker run ets --remote-on-host=dev.site.com will add x.x.x.x dev.site.com to /etc/hosts where x.x.x.x will be an ip of host machine based on docker.host.internal. That will be a great enhancement for Windows and Mac users.

Thank you.

webuniverseio commented 5 years ago

Does anyone monitor these issues?

TedShuter commented 5 years ago

Looks like we missed answering your question here, but we did see your question; it's been added to the enhancement backlog.