Closed hiroyukikumazawa closed 3 months ago
For issue #227
@hiroyukikumazawa We usually add this into commits. E.g.
fix: remove 'Upload SDL' button in other templates
refs #227
@hiroyukikumazawa another thing I noticed is it seems you haven't used our linter and formatter. We're going to add that as a pre-commit hook. However in the meanwhile please run before commit/push:
npm run lint -- --fix
npm run format
I'd suggest you enable that in your IDE, should ease the whole thing generally.
@hiroyukikumazawa another thing I noticed is it seems you haven't used our linter and formatter. We're going to add that as a pre-commit hook. However in the meanwhile please run before commit/push:
npm run lint -- --fix npm run format
I'd suggest you enable that in your IDE, should ease the whole thing generally.
So many files have been changed even though that I didn't change. @ygrishajev
@hiroyukikumazawa another thing I noticed is it seems you haven't used our linter and formatter. We're going to add that as a pre-commit hook. However in the meanwhile please run before commit/push:
npm run lint -- --fix npm run format
I'd suggest you enable that in your IDE, should ease the whole thing generally.
So many files have been changed even though that I didn't change. @ygrishajev
@hiroyukikumazawa That must me EOLs. If so I think u should be safe to commit. This don't appear on diff eventually.
That must me EOLs. If so I think u should be safe to commit. This don't appear on diff eventually
There are a lot of these changes.
That must me EOLs. If so I think u should be safe to commit. This don't appear on diff eventually
There are a lot of these changes.
Ah, changes like these are fine. There's eslint rule to sort imports. Someone else must have not used it before u
There are a lot of these changes.
Ah, changes like these are fine. There's eslint rule to sort imports. Someone else must have not used it before u
Right, so I will commit the changes. Are you ok?
There are a lot of these changes.
Ah, changes like these are fine. There's eslint rule to sort imports. Someone else must have not used it before u
Right, so I will commit the changes.
Are you ok?
Yea, just make a separate commit for the review. I'll check if anything's off.
There are a lot of these changes.
Ah, changes like these are fine. There's eslint rule to sort imports. Someone else must have not used it before u
Right, so I will commit the changes. Are you ok?
Yea, just make a separate commit for the review. I'll check if anything's off.
Ok
@hiroyukikumazawa That commit looks good to me. It's a lot of changes indeed but this has to be done anyway. Thanks for doing this. Let's see if others are aligned on leaving it in this pr.
We may have to comment out the "Plain Linux" tile for now. Otherwise LGTM 👍
Please squash commits before merging. Would be nice if we could keep formatting separately though
Please squash commits before merging. Would be nice if we could keep formatting separately though
done squash please check again. @ygrishajev
Please squash commits before merging. Would be nice if we could keep formatting separately though
done squash please check again. @ygrishajev
@hiroyukikumazawa lgtm! thanks again for ur contribution! good job 💪
@hiroyukikumazawa for your future contributions pls try using rebase instead of merge. Let's keep it as is for now though :)
@hiroyukikumazawa for your future contributions pls try using rebase instead of merge. Let's keep it as is for now though :)
done, please check again
refs #227