akash-network / console

Deploy docker containers on the Akash Network
https://console.akash.network
Apache License 2.0
56 stars 46 forks source link

feat: merge "Upload SDL" to "Build your template" and add "Plain Linux" template #244

Closed hiroyukikumazawa closed 3 months ago

hiroyukikumazawa commented 3 months ago

refs #227

ygrishajev commented 3 months ago

For issue #227

@hiroyukikumazawa We usually add this into commits. E.g.

fix: remove 'Upload SDL' button in other templates

refs #227
ygrishajev commented 3 months ago

@hiroyukikumazawa another thing I noticed is it seems you haven't used our linter and formatter. We're going to add that as a pre-commit hook. However in the meanwhile please run before commit/push:

npm run lint -- --fix
npm run format

I'd suggest you enable that in your IDE, should ease the whole thing generally.

hiroyukikumazawa commented 3 months ago

@hiroyukikumazawa another thing I noticed is it seems you haven't used our linter and formatter. We're going to add that as a pre-commit hook. However in the meanwhile please run before commit/push:

npm run lint -- --fix
npm run format

I'd suggest you enable that in your IDE, should ease the whole thing generally.

So many files have been changed even though that I didn't change. @ygrishajev

ygrishajev commented 3 months ago

@hiroyukikumazawa another thing I noticed is it seems you haven't used our linter and formatter. We're going to add that as a pre-commit hook. However in the meanwhile please run before commit/push:


npm run lint -- --fix

npm run format

I'd suggest you enable that in your IDE, should ease the whole thing generally.

So many files have been changed even though that I didn't change. @ygrishajev

@hiroyukikumazawa That must me EOLs. If so I think u should be safe to commit. This don't appear on diff eventually.

hiroyukikumazawa commented 3 months ago

That must me EOLs. If so I think u should be safe to commit. This don't appear on diff eventually

image

There are a lot of these changes.

ygrishajev commented 3 months ago

That must me EOLs. If so I think u should be safe to commit. This don't appear on diff eventually

image

There are a lot of these changes.

Ah, changes like these are fine. There's eslint rule to sort imports. Someone else must have not used it before u

hiroyukikumazawa commented 3 months ago

There are a lot of these changes.

Ah, changes like these are fine. There's eslint rule to sort imports. Someone else must have not used it before u

Right, so I will commit the changes. Are you ok?

ygrishajev commented 3 months ago

There are a lot of these changes.

Ah, changes like these are fine. There's eslint rule to sort imports. Someone else must have not used it before u

Right, so I will commit the changes.

Are you ok?

Yea, just make a separate commit for the review. I'll check if anything's off.

hiroyukikumazawa commented 3 months ago

There are a lot of these changes.

Ah, changes like these are fine. There's eslint rule to sort imports. Someone else must have not used it before u

Right, so I will commit the changes. Are you ok?

Yea, just make a separate commit for the review. I'll check if anything's off.

Ok

ygrishajev commented 3 months ago

@hiroyukikumazawa That commit looks good to me. It's a lot of changes indeed but this has to be done anyway. Thanks for doing this. Let's see if others are aligned on leaving it in this pr.

baktun14 commented 3 months ago

We may have to comment out the "Plain Linux" tile for now. Otherwise LGTM 👍

ygrishajev commented 3 months ago

Please squash commits before merging. Would be nice if we could keep formatting separately though

hiroyukikumazawa commented 3 months ago

Please squash commits before merging. Would be nice if we could keep formatting separately though

done squash please check again. @ygrishajev

ygrishajev commented 3 months ago

Please squash commits before merging. Would be nice if we could keep formatting separately though

done squash please check again. @ygrishajev

@hiroyukikumazawa lgtm! thanks again for ur contribution! good job 💪

ygrishajev commented 3 months ago

@hiroyukikumazawa for your future contributions pls try using rebase instead of merge. Let's keep it as is for now though :)

hiroyukikumazawa commented 3 months ago

@hiroyukikumazawa for your future contributions pls try using rebase instead of merge. Let's keep it as is for now though :)

done, please check again