search

akash-network / console

Deploy docker containers on the Akash Network
https://console.akash.network
Apache License 2.0
43 stars 34 forks source link

feat/update elements to v1.3.3 #257

Closed siddharthborderwala closed 1 day ago

siddharthborderwala commented 2 weeks ago

Update @leapwallet/elements to that latest version (v1.3.3)

It features UX updates as well as added support for Fiat on-ramp via Kado.

baktun14 commented 1 week ago

Hey @siddharthborderwala, thanks for updating Elements. Is this ready to review?

siddharthborderwala commented 1 week ago

Hi @baktun14 it's ready to review.

baktun14 commented 1 week ago

@siddharthborderwala I tested it locally and it looks good. There was some conflicts in the package-lock file that I resolved and rebased from main.

baktun14 commented 1 week ago

I get this error when opening the modal, going somewhere in the app and coming back. image

siddharthborderwala commented 4 days ago

@baktun14 I will check this out

siddharthborderwala commented 4 days ago

@baktun14 I'm not able to reproduce the error with the steps you have specified. Can you check again? It might have been a one-off error on the dev server.

baktun14 commented 3 days ago

@siddharthborderwala I don't know how it happens, but I was able to reproduce it once. I changed wallet on the get started page and then created a deployment, then came back and had the error. There's also an hydration error when changing wallet. image

siddharthborderwala commented 2 days ago

@baktun14 The error you faced might be a one-off and it comes from Rainbowkit (ETH wallet adapter). If it happens again, we will look into it.

And for the hydration error, we are aware of the issue and will fix it in the coming releases. It won't affect the application.

We recommend going forward with v1.3.3 as it's the stable version with all latest features elements has to offer. We're even using it on SwapFast.

baktun14 commented 1 day ago

@baktun14 The error you faced might be a one-off and it comes from Rainbowkit (ETH wallet adapter). If it happens again, we will look into it.

And for the hydration error, we are aware of the issue and will fix it in the coming releases. It won't affect the application.

We recommend going forward with v1.3.3 as it's the stable version with all latest features elements has to offer. We're even using it on SwapFast.

Alright we'll do that. If I see the error again I will report back.