akash-network / console

Deploy docker containers on the Akash Network
https://console.akash.network
Apache License 2.0
84 stars 55 forks source link

Ensure logger works in all environments #430

Open ygrishajev opened 3 weeks ago

ygrishajev commented 3 weeks ago

Depends on #429

The logger as described in #429 wold only work in nodejs environment. We need to make sure it's hybrid and can work in any environment. To do so we need to adjust it to import dependencies dynamically based on environment and packages present in node_modules.

Acceptance criteria:

forbesus commented 2 weeks ago

hello @ygrishajev i checked this issue and package is working well on browser and nodejs so i think we can integrate this in another apps

ygrishajev commented 2 weeks ago

@forbesus ok, cool. Let's start with #436 then. I think some issues might still pop up. E.g. config might not work with process env properly. We'll also need it on external packages once it is published. So this needs to be tested against built dist.

forbesus commented 1 week ago

hello @ygrishajev previous weekend, i checked all pino documentation again we are using pino-fluentd and pino-pretty modules for logging package now and fluentd and pretty all were designed for server side and working with only nodejs

i am sorry for previous confusing and didn't check about fluentd and pretty

ygrishajev commented 1 week ago

@forbesus No prob. Is it only fluentd? I don't think it's needed anymore. Let's just remove it