search

akash-network / console

Deploy docker containers on the Akash Network
https://console.akash.network
Apache License 2.0
84 stars 55 forks source link

feat(sdl): can set credentials #479

Closed jzsfkzm closed 3 days ago

jzsfkzm commented 4 days ago

One can select an image repository and enter credentials after this. Available in the SDL Builder, but not in the deployment UI.

ref #467

jzsfkzm commented 3 days ago

The credentials for private repos are optional, since not all repos are private. The way you implemented it is great, we just need to add a flag like "hasGpu" and conditionally add the validation. So a simple checkbox like the hasGpu to toggle the form controls should do it.

Is there a reason behind the canChangeCredentials? We would like to have it in all the SDL builder instances (SDL Builder page and new deployment page).

I added the flag canChangeCredentials because I figured it is not needed for templates on the Deploy page. Now I see it is very much needed there too, so removed. Now it is all the same for Deploy and SDL Builder. Added a checkbox with label "Private" on top the box, revealing credential fields only when you click it.