search

akeneo / Dockerfiles

DEPRECATED for PIM 4.0 and above - Official Dockerfiles for Akeneo development and testing
https://hub.docker.com/r/akeneo/
MIT License
49 stars 34 forks source link

Remove comment about working directory in Dockerfile #319

Closed jmleroux closed 6 years ago

jmleroux commented 6 years ago

Description

The previous comment was not correct. Plus, the command itself is explicit, so the best soltuion is to not have any comment.

Definition Of Done

Q A
Added tests -
Changelog updated -
Documentation Yes
Fixed tickets -

Todo: Pending / Work in progress OK: Done / Validated -: Not needed

jmleroux commented 6 years ago

I rebased my branch and edited the PR description

damien-carcel commented 6 years ago

I am gonna be "lourd", but you forgot the new PHP 7.2 Dockerfile :smile:. After that it will be GTM.

damien-carcel commented 6 years ago

Merged. Thank you for this fix @jmleroux