akeneo / Dockerfiles

DEPRECATED for PIM 4.0 and above - Official Dockerfiles for Akeneo development and testing
https://hub.docker.com/r/akeneo/
MIT License
49 stars 34 forks source link

Revert removing of php7.0-mbstring and php7.1-mbstring #332

Closed willy-ahva closed 5 years ago

willy-ahva commented 5 years ago

Description

There was a bug on the PIM: mb_string was used somewhere on the PIM but not required. So people install without mb_string and had a bug. What was did is to remove the use of mb_string in the PIM and remove the extension from docker/ansible.

But it seems that behat need mb_string.

[2.3 ?]$ docker-compose exec fpm composer install --prefer-dist

Loading composer repositories with package information Updating dependencies (including require-dev) Your requirements could not be resolved to an installable set of packages.

Problem 1

Definition Of Done

Q A
Added tests Todo
Changelog updated Todo
Documentation -
Fixed tickets #...

Todo: Pending / Work in progress OK: Done / Validated -: Not needed

AymericPlanche commented 5 years ago

:-1: mbstring is not an extension required by the pim, it doesn't have to be in the docker image.

see https://akeneo.atlassian.net/browse/PIM-7903

and

https://akeneo.slack.com/archives/CAT7MQP9D/p1543920319019700

EDIT: didn't read the description, ok for behat...