search

akeneo / Dockerfiles

DEPRECATED for PIM 4.0 and above - Official Dockerfiles for Akeneo development and testing
https://hub.docker.com/r/akeneo/
MIT License
49 stars 34 forks source link

Add PHP 7.3 support (closes #329) #337

Closed stefandoorn closed 5 years ago

stefandoorn commented 5 years ago

Definition Of Done

Q A
Added tests OK
Changelog updated OK
Documentation OK
Fixed tickets #329

Todo: Pending / Work in progress OK: Done / Validated -: Not needed

damien-carcel commented 5 years ago

akeneo:php and akeneo:fpm are available on Docker Hub for PHP 7.3 :tada:

stefandoorn commented 5 years ago

You're welcome @damien-carcel. What about the Apache/PHP setup for 7.2 & 7.3? Is that discontinued or just not implemented yet?

damien-carcel commented 5 years ago

akeneo/apache-php is indeed discontinued. We are only using FPM now. The 7.0 and 7.1 versions were experimental, only the 5.6 version is used with Akeneo 1.7. And as it will reach end of support by the end of March, we will fully deprecate akeneo/apache-php, remove them from the GitHub repository and not build them anymore (current tags will stay on the Docker hub).

stefandoorn commented 5 years ago

@damien-carcel Actually I figured out today that Akeneo itself is not compatible with PHP 7.3 due to older Doctrine versions: https://github.com/akeneo/pim-community-dev/issues/9623. Although it's not the responsibility of the Docker set-up, it would maybe make sense to test an installation on the Docker files also? That's what they are intended for in the end.. :-)

damien-carcel commented 5 years ago

Indeed, they are.

We know Akeneo 3.x cannot support PHP 7.3 because of several dependencies (there were also a few issues with some of our dev dependencies when I checked before Christmas).

We couldn't work on it for Akeneo 3.x because of the tied schedule, but Akeneo 4.x (next year major release) will very probably require PHP 7.3, maybe PHP 7.4 if we have the time to test it and find no major issues.

Creating images for the new PHP versions is the first step for that (now done thanks to you :slightly_smiling_face:).

stefandoorn commented 5 years ago

That's a pity. It would be great if 3.x is going to support it (not necessarily require it), because active support for PHP 7.2 ends already in 9 months from now.