search

akeneo / Dockerfiles

DEPRECATED for PIM 4.0 and above - Official Dockerfiles for Akeneo development and testing
https://hub.docker.com/r/akeneo/
MIT License
49 stars 34 forks source link

Simplify PHP_XDEBUG_ENABLED condition #340

Closed lars85 closed 5 years ago

lars85 commented 5 years ago

Conditions for PHP_XDEBUG_ENABLED can be simplified in entrypoint.sh files.

lars85 commented 5 years ago

https://www.shellcheck.net/ says

Line 35:
if [ ! -z "${PHP_XDEBUG_ENABLED}" ]; then
     ^-- SC2236: Use -n instead of ! -z.

in old version (current master).

My patch would also solve this problem.

damien-carcel commented 5 years ago

Hey Lars.

Thank you so much for this contribution. I merged your PR, the Docker Hub is currently building the new images. I'll close this issue when the build is complete (should be by the end of the morning).

Cheers, Damien.