search

akhawaja / ksuid

Java implementation of K-Sortable Globally Unique IDs
Other
41 stars 9 forks source link

Base62 is not thread safe #3

Closed kosprov closed 5 years ago

kosprov commented 5 years ago

Hi,

Your implementation of Base62 uses a static variable for the StringBuilder that collects output characters. This makes it non-thread-safe and cannot be used in a server environment.

akhawaja commented 5 years ago

Hi @kosprov. I take your point and will revisit the Base62 class as time permits. Cheers!

akhawaja commented 5 years ago

Hi @kosprov. Going forward, I intend to remove the Base62 class included in this library in favor of one that is available on Maven Central. I am closing this issue. Thank you for examining the repository and offering your feedback.