search

akloeckner / hacs-hafas

Port of kilimnik's HAFAS client for HACS
5 stars 2 forks source link

"unknown" error during config flow #2

Closed akloeckner closed 1 year ago

akloeckner commented 1 year ago

When evaluating the station name (presumably), an unspecific error occurs, resulting in "unknown" to be displayed to the user. I guess, that originates somewhere here:

https://github.com/akloeckner/hacs-hafas/blob/c6d6ce0811d4488285ad8ebdfad38264e100efc5/custom_components/hafas/config_flow.py#L161

@enjoysimpson, I thought we'd better split this issue from the general setup issue #1.

kilimnik commented 1 year ago

I debugged this a bit and came to the conclusion, it's the library pyhafas's fault. When requesting stations the response it gets from the db hafas apii s{'ver': '1.16', 'ext': 'DB.R19.04.a', 'lang': 'deu', 'id': '', 'err': 'CLIENTVERSION', 'cInfo': {'code': 'VD'}, 'svcResL': []}.

So, it seems, that the hafas api is updates somehow.

Unfortunately the pyhafas library does not look maintained anymore. I will look into this some more.

akloeckner commented 1 year ago

🙄 Let's hope, we don't need to fork pyhafas and learn how to publish it to pypi...

enjoysimpson commented 1 year ago

@akloeckner thanks for moving my topic to here. @kilimnik thanks for looking into this. I like the idea of connecting to the HAFAS interface way more, than the web scraping done by the DB integration. I'm not able to help you with editing the source code. But I would be happy to test if needed. I cross the fingers you will find a solution.

akloeckner commented 1 year ago

I just checked the commit mentioned above and it seems to have fixed the issue.